-
-
Notifications
You must be signed in to change notification settings - Fork 468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove all functions from the auto escape list that don't return a value #1349
Conversation
Has a merge conflict. |
I've reviewed the functions removed in the current pull request. I agree with all functions removed in 1ffc427 I've also gone through the list of remaining items in the 'autoEscapedFunctions' property.
|
@johnbillion Thank you for the PR. Would you mind rebasing it on the current @NielsdeBlaauw Thank you for your detailed review & I look forward to your pull request for your other finds! |
@johnbillion Just checking - did you see my previous message asking to rebase ? |
Closing in favour of #1547 since @johnbillion hasn't fixed the merge conflict. |
@NielsdeBlaauw Sorry - I missed your comment. If you want to open a PR with your recommended additional changes here, then we can take a look :-) Thanks! |
Fixes #1348