RestrictedPHPFunctions: add error for use of date() #1714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrfnl
added
Type: Enhancement
Status: Review ready
Component: Core
Focus: WP interoperability
GaryJones
approved these changes
May 29, 2019
As this sniff is already included in the WP Core ruleset and the enhancement request is about PHP native functions, this seemed liked a logical sniff to add this to. I've elected to make this an `error` instead of a `warning` as the code within WP Core has been cleaned up for this issue now and it would be good to prevent new instances of `date()` creeping in. Fixes 1713
jrfnl
force-pushed
the
feature/1713-restrictedphpfunctions-add-date
branch
from
9eb5d49
to
d0b9d93
Compare
|
Rebased to get a passing build after the move. @GaryJones Feel free to merge this if all is good.
|
jrfnl
added
Focus: DateTime
and removed
Focus: WP interoperability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As this sniff is already included in the WP Core ruleset and the enhancement request is about PHP native functions, this seemed liked a logical sniff to add this to.
I've elected to make this an
errorinstead of awarningas the code within WP Core has been cleaned up for this issue now and it would be good to prevent new instances ofdate()creeping in.Fixes #1713