Docs/WordPress.WhiteSpace.PrecisionAlignment #1725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GaryJones
approved these changes
Jun 23, 2019
jrfnl
requested changes
Jun 27, 2019
There was a problem hiding this comment.
Hi @ckanitz Thank you so much for this PR.
Generally speaking, it looks good. Just a few minor suggestions from my side.
Also: could you please make sure the indentation within the XML file is consistently done with spaces ?
The current file seems to have a mix of space/tab indentation.
| </code> | ||
| </code_comparison> | ||
| <code_comparison> | ||
| <code title="Valid: four spaces will be replaced by the upstream sniff."> |
There was a problem hiding this comment.
Suggested change
| <code title="Valid: four spaces will be replaced by the upstream sniff."> | |
| <code title="Valid: four spaces counts as a tab, the replacement of these will be handled by another sniff."> |
jrfnl
requested changes
Jun 27, 2019
jrfnl
reviewed
Jul 1, 2019
Co-Authored-By: Juliette <663378+jrfnl@users.noreply.github.com>
Co-Authored-By: Juliette <663378+jrfnl@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds documentation for the WordPress.WhiteSpace.PrecisionAlignmentSniff
Related to #1722