Documentation: New error handling Deprecated Classes and Functions #1729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GaryJones
requested changes
Jun 23, 2019
There was a problem hiding this comment.
Are the valid and invalid examples correct here?
I see different parameter names in the examples, but the description is about values.
In this case, it should be string values that are used, not variable names:
Valid:
bloginfo( 'url' );
$tagline = get_bloginfo( 'description' );Invalid:
bloginfo( 'siteurl' );
$home_url = get_bloginfo( 'home' );These examples also then include indicators that it applies to bloginfo() and get_bloginfo().
Please also see the other comments.
GaryJones
approved these changes
Jun 24, 2019
GaryJones
requested changes
Jun 24, 2019
|
FYI: @fkeijzer and me have sat down together at WordCamp Nijmegen today to review this. The changes I've pushed now in the second commit have been made by us together. @GaryJones Would you like to do one last look over ? (and merge if deemed ok) |
jrfnl
approved these changes
Sep 20, 2019
jrfnl
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1722