Docs/WordPress.WhiteSpace.CastStructureSpacing #1738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GaryJones
requested changes
Jun 23, 2019
GaryJones
requested changes
Jun 25, 2019
jrfnl
requested changes
Jul 1, 2019
There was a problem hiding this comment.
@ckanitz Hi Christopher, thank you again for this PR.
Just two more points as per the inline comments:
- The sniff only checks the space before, not on both sides of the type cast.
- The docs are just missing the
<em> ...</em>tags to highlight good/bad code, but we weren't that clear about that in the initial explanation, so sorry about that!.
Co-Authored-By: Juliette <663378+jrfnl@users.noreply.github.com>
Co-Authored-By: Juliette <663378+jrfnl@users.noreply.github.com>
Co-Authored-By: Juliette <663378+jrfnl@users.noreply.github.com>
Thanks for your reply and sorry for checking out so late. I commited the changes you suggested. Are there any changes left for me to add? |
Co-Authored-By: Juliette <663378+jrfnl@users.noreply.github.com>
Co-Authored-By: Juliette <663378+jrfnl@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds documentation for the WordPress.WhiteSpace.CastStructureSpacing
Related to #1722