Added remaining plugin load globals #1755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dingo-d
added
Focus: WP interoperability
GaryJones
approved these changes
Jul 2, 2019
jrfnl
approved these changes
Jul 2, 2019
There was a problem hiding this comment.
Verified & approved.
For future reference, these global variables are defined:
$mu_plugin: https://core.trac.wordpress.org/browser/trunk/src/wp-settings.php#L293$network_plugin: https://core.trac.wordpress.org/browser/trunk/src/wp-settings.php#L309
... and unset() straight after the loop finishes.
Just like $plugin in PR #1754, a variable override of these variable will only cause a problem if the plugin being loaded declares the variable in the global namespace in the initial network/mu-plugin file being loaded - or in any plugin files being loaded directly when the initial file is read.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #1754 with two more globals related to plugin load.