WordPress ruleset: efficiency fix #1758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rulesets are processed top-to-bottom, one rule at the time. For the `WordPress` ruleset, this means that PHPCS would first load the `WordPress-Core` ruleset and process all rules in that file, then read the `WordPress-Docs` ruleset and lastly, the `WordPress-Extra` ruleset. As the `WordPress-Extra` ruleset includes `WordPress-Core`, it would re-process the `WordPress-Core` ruleset a second time and then process the additional rules in the `Extra` ruleset. This means that in effect, the `WordPress-Core` ruleset is processed twice when using the `WordPress` ruleset which is inefficient. By commenting that rule out, we still document that the `WordPress` ruleset includes `WordPress-Core` without double processing the ruleset.
GaryJones
approved these changes
Jul 5, 2019
dingo-d
approved these changes
Jul 5, 2019
|
@dingo-d Feel free to merge this ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rulesets are processed top-to-bottom, one rule at the time.
For the
WordPressruleset, this means that PHPCS would first load theWordPress-Coreruleset and process all rules in that file, then read theWordPress-Docsruleset and lastly, theWordPress-Extraruleset.As the
WordPress-Extraruleset includesWordPress-Core, it would re-process theWordPress-Coreruleset a second time and then process the additional rules in theExtraruleset.This means that in effect, the
WordPress-Coreruleset is processed twice when using theWordPressruleset which is inefficient.By commenting that rule out, we still document that the
WordPressruleset includesWordPress-Corewithout double processing the ruleset.