New DisallowShortTernary sniff #1768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This new sniff addresses the new "_The short ternary operator must not be used._" rule which was recently added to the handbook. The sniff has been added to the `WordPress-Core` ruleset. Refs: * https://make.wordpress.org/core/handbook/best-practices/coding-standards/php/#ternary-operator * https://make.wordpress.org/core/2019/07/12/php-coding-standards-changes/ Includes unit tests. Includes documentation.
dingo-d
reviewed
Jul 21, 2019
| </code> | ||
| <code title="Invalid: short ternary."> | ||
| <![CDATA[ | ||
| $height = $data['height'] <em>? :</em> 0; |
There was a problem hiding this comment.
The space between ? and : is intentional?
There was a problem hiding this comment.
Yes. WPCS has no specific rules about the formatting of short ternaries and considering they will be banned, specifying such rules has low priority.
In the absence of specific rules, WPCS will treat the ? and : the same way as other operators and demands whitespace on both sides.
In other words, the formatting complies with the CS rules for this piece of code as per current WPCS.
dingo-d
approved these changes
Jul 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new sniff addresses the new "The short ternary operator must not be used." rule which was recently added to the handbook.
The sniff has been added to the
WordPress-Coreruleset.Refs:
Includes unit tests.
Includes documentation.
Loosely related to #764