EscapeOutput: improve the error message for non-escaped variables #1776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This improved the error message output when array variables are being accessed. ```php echo $strings['update-available']; ``` **Old output:** `All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$strings'.` **New output:** `All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$strings['update-available']'.` No unit tests added as the unit tests don't test the message thrown. The effect can be tested & confirmed though by running the sniff over the above code snippet. Partially fixes 749
GaryJones
approved these changes
Jul 23, 2019
dingo-d
approved these changes
Jul 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improved the error message output when array variables are being accessed.
Old output:
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$strings'.New output:
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$strings['update-available']'.No unit tests added as the unit tests don't test the message thrown.
The effect can be tested & confirmed though by running the sniff over the above code snippet.
Partially fixes #749