New "DateTime.RestrictedFunctions" sniff #1807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dingo-d
approved these changes
Oct 13, 2019
GaryJones
approved these changes
Oct 16, 2019
This introduces a new `WordPress.DateTime.RestrictedFunctions` sniff which initially includes two groups: * `timezone_change` - moved from the `WordPress.WP.TimezoneChange` sniff * `date` - moved from the `WordPress.PHP.RestrictedPHPFunctions` sniff (group not yet in a released WPCS version yet) The `WordPress.WP.TimezoneChange` sniff is now deprecated. * The sniff is no longer included in the WPCS rulesets. * If the sniff is explicitly included via a custom ruleset, deprecation notices will be thrown. * If the `exclude` property is set from with a custom ruleset, a deprecation notice will be thrown. The new sniff is now included in the `Core` ruleset. Note: once WP Core upgrades, the one instance of using `date_default_timezone_set()` in WP Core (in `wp-settings.php`) will need to be whitelisted inline. There are a few more occurrences in the unit tests, but those can be ignored via file based excludes. Fixes 1805
jrfnl
force-pushed
the
feature/1805-new-category-datetime
branch
from
e464420
to
7947bce
Compare
This was referenced Jun 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a new
WordPress.DateTime.RestrictedFunctionssniff which initially includes two groups:timezone_change- moved from theWordPress.WP.TimezoneChangesniffdate- moved from theWordPress.PHP.RestrictedPHPFunctionssniff (group not yet in a released WPCS version yet)The
WordPress.WP.TimezoneChangesniff is now deprecated.excludeproperty is set from with a custom ruleset, a deprecation notice will be thrown.The new sniff is now included in the
Coreruleset.Note: once WP Core upgrades, the one instance of using
date_default_timezone_set()in WP Core (inwp-settings.php) will need to be whitelisted inline.There are a few more occurrences in the unit tests, but those can be ignored via file based excludes.
Fixes #1805