EscapeOutput: allow for typical pattern with _deprecated_file()
#1818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The first parameter passed to `_deprecated_file()` generally is `basename( __FILE__ )` based on the code currently in WP Core. As the result of that function call is safe, I'm proposing making an exception for that particular code pattern. Includes unit tests. Note: the current code does not allow for comments in the first parameter. This would be rare encounter in these function calls anyway and allowance for it can be added later if needs be.
GaryJones
approved these changes
Oct 27, 2019
dingo-d
approved these changes
Oct 27, 2019
dingo-d
deleted the
feature/escapeoutput-tolerance-first-param-deprecated-file
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first parameter passed to
_deprecated_file()generally isbasename( __FILE__ )based on the code currently in WP Core.As the result of that function call is safe, I'm proposing making an exception for that particular code pattern when used as the first param in a call to
deprecated_file().Includes unit tests.
Note: the current code does not allow for comments in the first parameter. This would be rare to encounter in these function calls anyway and allowance for it can be added later if needs be.