PrefixAllGlobals: minor efficiency tweak #1822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrfnl
force-pushed
the
feature/prefixallglobals-efficiency-tweak
branch
from
75d6a76
to
ef7f86e
Compare
Similar to 1815, but then for the `PrefixAllGlobals` sniff, allowing it to fail earlier for calls to deprecated hooks.
dingo-d
approved these changes
Oct 29, 2019
GaryJones
approved these changes
Oct 30, 2019
There was a problem hiding this comment.
Your PR has passed VIP code review. You can now merge into master to deploy when you are ready. Find out more in our documentation.
Er... looks good to me!
(Sorry, habit of reviewing and approving many, many PRs!)
|
@GaryJones Comment for the wrong repo ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #1815, but then for the
PrefixAllGlobalssniff, allowing it to fail earlier for calls to deprecated hooks.