3.0: Remove the PHPCSHelper class #1922
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... in favour of the PHPCSUtils version of that class which adds:
For full details on the upstream class, see the PHPCSHelper class documentation for PHPCSUtils.
The removal is done in three steps, which correspond to the commits in this PR:
Doing this removal in steps allowed for testing in between, making sure every use of the old class was caught.
Commit Details
PHPCSHelper: deprecate the class and all the methods in it
As everything here is now contained within PHPCSUtils, including updated and/or improved versions of some of these.
PHPCSHelper::get_version(): remove call to the function
This function call is no longer needed now support for PHPCS < 3.5.0 has been dropped.
PHPCSHelper::get_config_data(): switch over to the PHPCSUtils version
PHPCSHelper::get_tab_width(): switch over to the PHPCSUtils version
Remove the PHPCSHelper.php file
All of the methods contained herein are now provided via PHPCSUtils and all code has been switched over to use the PHPCSUtils versions of the methods instead.