WP/CronInterval: bugfix for fully qualified time constants #2073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GaryJones
requested changes
Aug 8, 2022
jrfnl
added a commit
that referenced
this pull request
Aug 8, 2022
|
Added a second commit addressing the review remarks for easier verification, Please squash the commit on merge (or I can squash and force push ahead of merge). |
GaryJones
approved these changes
Aug 8, 2022
jrfnl
force-pushed
the
feature/wp-croninterval-bugfix-fully-qualified-constants
branch
from
6784816
to
fe09fed
Compare
dingo-d
pushed a commit
that referenced
this pull request
Aug 9, 2022
See: #2073 (comment) Co-authored-by: jrfnl <jrfnl@users.noreply.github.com>
If the WP time constants would be used in their fully qualified form, as is often encountered in namespaced files, the sniff would no longer be able to correctly determine the interval being scheduled. This commit fixes that. Note: To prevent constants from a different namespace accidentally matching the WP native constants, the namespace separator is replace by a space character rather than just ignored. The regex before running the `eval()` will prevent code with identifier names other than the WP time constants from being passed to the `eval()`, meaning those will still be reported as "interval undetermined". Includes unit tests.
jrfnl
force-pushed
the
feature/wp-croninterval-bugfix-fully-qualified-constants
branch
from
fe09fed
to
935257b
Compare
|
I've rebased the PR (without changes) to get passed the imaginary merge conflict. I've squashed the second commit with the updates after review into the first one now as well, so if found okay, this PR can now be merged normally. |
dingo-d
approved these changes
Aug 10, 2022
dingo-d
deleted the
feature/wp-croninterval-bugfix-fully-qualified-constants
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the WP time constants would be used in their fully qualified form, as is often encountered in namespaced files, the sniff would no longer be able to correctly determine the interval being scheduled.
Note: To prevent constants from a different namespace accidentally matching the WP native constants, the namespace separator is replaced by a space character rather than just ignored. The regex before running the
eval()will prevent code with identifier names other than the WP time constants from being passed to theeval(), meaning those will still be reported as "interval undetermined".This commit fixes that.
Includes unit tests.