Core: add sniff to enforce the use of __DIR__ instead of dirname(__FILE__) #2137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…LE__) Related to previous efforts which already fixed all instances of this in WP Core. The sniff from PHPCSExtra includes an auto-fixer for the issue. Note: the sniff from PHPCSExtra also contains a check for nested `dirname()` function calls. This check is not (yet) enabled as the fix for this requires PHP 7.0+. Fixes 1954 Refs: * PHPCSStandards/PHPCSExtra 172 * PHPCSStandards/PHPCSExtra 187 Related to WP Core tickets: * https://core.trac.wordpress.org/ticket/48082 * https://core.trac.wordpress.org/changeset/47198
dingo-d
approved these changes
Dec 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to previous efforts which already fixed all instances of this in WP Core.
The sniff from PHPCSExtra includes an auto-fixer for the issue.
Note: the sniff from PHPCSExtra also contains a check for nested
dirname()function calls. This check is not (yet) enabled as the fix for this requires PHP 7.0+.Fixes #1954
Refs:
Related to WP Core tickets: