Move is_class_object_call() utility method to dedicated ContextHelper + support nullsafe object operator
#2226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…per` The `is_class_object_call()` utility method is only used by a small set of sniffs, so is better placed in a dedicated class. This commit moves the `is_class_object_call()` method to the new `WordPressCS\WordPress\Helpers\ContextHelper` class and starts using that class in the relevant sniffs. The method has also been renamed to `has_object_operator_before()` as it doesn't actually check if something is a (method) _call_, just that something OO (method, constant, property) is being accessed. Related to 1465 This method is tested via the `WordPress.WP.DiscouragedFunctions` sniff.
…support PHP 8.0 nullsafe object operator * A non-inline HTML token will always have another non-empty token before it, if nothing else, the PHP open tag, so checking if `$before` is `false` is redundant. * Implement use of the `Collections::objectOperators()` token group, which includes the PHP 8.0+ nullsafe object operator. _Note: this automatically adds support for the nullsafe object operator to all sniffs using this method, either directly or indirectly._ Includes test via the `WordPress.WP.DiscouragedFunctions` sniff.
dingo-d
approved these changes
Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this PR is part of a series moving various method to this new
ContextHelperclass. Pulling each bit separately to allow for easier reviewing.Move is_class_object_call() utility method to dedicated
ContextHelperThe
is_class_object_call()utility method is only used by a small set of sniffs, so is better placed in a dedicated class.This commit moves the
is_class_object_call()method to the newWordPressCS\WordPress\Helpers\ContextHelperclass and starts using that class in the relevant sniffs.The method has also been renamed to
has_object_operator_before()as it doesn't actually check if something is a (method) call, just that something OO (method, constant, property) is being accessed.Related to #1465
This method is tested via the
WordPress.WP.DiscouragedFunctionssniff.ContextHelper::has_object_operator_before(): simplify/use PHPCSUtils/support PHP 8.0 nullsafe object operator
$beforeisfalseis redundant.Collections::objectOperators()token group, which includes the PHP 8.0+ nullsafe object operator.Note: this automatically adds support for the nullsafe object operator to all sniffs using this method, either directly or indirectly.
Includes test via the
WordPress.WP.DiscouragedFunctionssniff.