-
-
Notifications
You must be signed in to change notification settings - Fork 483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Escape output sniff fix for static method calls #2370
Open
dingo-d
wants to merge
15
commits into
develop
Choose a base branch
from
hotifx/escape-output-sniff
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Sep 22, 2023
-
Configuration menu - View commit details
-
Copy full SHA for a50ddd2 - Browse repository at this point
Copy the full SHA a50ddd2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 39ef8e9 - Browse repository at this point
Copy the full SHA 39ef8e9View commit details -
Configuration menu - View commit details
-
Copy full SHA for a4b4624 - Browse repository at this point
Copy the full SHA a4b4624View commit details -
Need to write a recursive method that will check the fully qualified class names and if they have a static method call in them. We should also be careful not to catch the throw Exception cases, as for those we do want to check the parameters of the static method if they are escaped or not.
Configuration menu - View commit details
-
Copy full SHA for 0da61dd - Browse repository at this point
Copy the full SHA 0da61ddView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2dd977c - Browse repository at this point
Copy the full SHA 2dd977cView commit details -
Configuration menu - View commit details
-
Copy full SHA for d48f71f - Browse repository at this point
Copy the full SHA d48f71fView commit details -
Add check for static public properties, enums and constants.
Configuration menu - View commit details
-
Copy full SHA for 9280466 - Browse repository at this point
Copy the full SHA 9280466View commit details -
Configuration menu - View commit details
-
Copy full SHA for 18df81f - Browse repository at this point
Copy the full SHA 18df81fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 92492aa - Browse repository at this point
Copy the full SHA 92492aaView commit details -
Configuration menu - View commit details
-
Copy full SHA for f9f0bdc - Browse repository at this point
Copy the full SHA f9f0bdcView commit details -
Update the escaping functions trait
Add a way to identify static methods in the is_escaping_function, used for setting the customEscapingFunctions.
Configuration menu - View commit details
-
Copy full SHA for c4915b5 - Browse repository at this point
Copy the full SHA c4915b5View commit details -
Configuration menu - View commit details
-
Copy full SHA for e1c145e - Browse repository at this point
Copy the full SHA e1c145eView commit details -
Configuration menu - View commit details
-
Copy full SHA for d02d85f - Browse repository at this point
Copy the full SHA d02d85fView commit details -
Update the escaping functions trait
Split the merge function to merge lowercased method/function names, because PHP is case insensitive for all class, namespace and method names.
Configuration menu - View commit details
-
Copy full SHA for 21c5742 - Browse repository at this point
Copy the full SHA 21c5742View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4a48492 - Browse repository at this point
Copy the full SHA 4a48492View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.