Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the test case file path used in a CONTRIBUTING.md example #2418

Merged
merged 1 commit into from Dec 15, 2023

Conversation

rodrigoprimo
Copy link
Contributor

I believe the path of the test case file used in the example of how to generate the list of expected lines with errors is wrong. This PR fixes it.

Here is the commit that introduced the current version of the line that is changed in this PR: 4a33d46#diff-98e64bc1cd2db9333c6effe87bbe0d6dfe8714aba4c6bde45aa037fe0796e44cR141.

If we want to keep the current path for some reason, we might want to change the part that says "from the root directory of your WordPressCS clone".

The path of the test case file used in the example of how to generate
the list of expected lines with errors is wrong. This commit fixes it.

I believe it was changed by mistake in
WordPress@4a33d46#diff-98e64bc1cd2db9333c6effe87bbe0d6dfe8714aba4c6bde45aa037fe0796e44cR141.

If we want to keep the current path for some reason, we might want to
change the part that says "from the root directory of your WordPressCS
clone".
Copy link
Member

@jrfnl jrfnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@dingo-d dingo-d merged commit c49b8c3 into WordPress:develop Dec 15, 2023
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants