Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sniff to disallow alternative PHP open tags. #585

Merged
merged 4 commits into from Jul 25, 2016
Merged

Add sniff to disallow alternative PHP open tags. #585

merged 4 commits into from Jul 25, 2016

Commits on Jul 20, 2016

  1. Add sniff to disallow alternative PHP open tags. 

    Fixes WordPress#580

This should be removed again if the upstream issue squizlabs/PHP_CodeSniffer#1063 would get traction and the associated PR would be merged *and* the minimum PHPCS version for WPCS would become higher than the version in which the PR is merged ;-)
    @jrfnl
    jrfnl committed Jul 20, 2016
    Configuration menu
    Copy the full SHA
    961d13c View commit details
    Browse the repository at this point in the history

  2. Make alternative openings tags fixable. 

    Only implemented for when we are sure we've found alternative opening tags.
The 'maybe' causes which need manual inspection should not be auto-fixable.
    @jrfnl
    jrfnl committed Jul 20, 2016
    Configuration menu
    Copy the full SHA
    2cdba84 View commit details
    Browse the repository at this point in the history

  3. Rename sniff to DisallowAlternativePHPTags.

    @jrfnl
    jrfnl committed Jul 20, 2016
    Configuration menu
    Copy the full SHA
    be04587 View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2016

  1. Revisit the complete logic of the DisallowAlternativePHPTags Sniff.… 

    … New & improved version.

Includes additional unit tests.
    @jrfnl
    jrfnl committed Jul 22, 2016
    Configuration menu
    Copy the full SHA
    34d436f View commit details
    Browse the repository at this point in the history