Giving Props to Blueprint Community members #21
Comments
|
Great idea, although using GitHub is a prerequisite to both things (getting Props and submitting a Blueprint to this gallery) :-) Anyway, according to the announcement post you linked,
Seems like all that's needed is to set up the Props Bot GitHub action. |
Thank you for the important distinction :) |
|
+1 |
|
To gauge the documentation needs when thinking about Contributor badges, looking at other teams will help: The design team would also be involved to create the badge design for contributors and team members. It is also worth a discussion with the meta team if playground blueprint contributors should just receive meta Contributor badges and augment the team's badge documentation. |
|
@bph - Nice catch on the distinction. What's the difference between someone who builds a Would it be worthwhile as a "first contribution" to give credit for a Blueprint? When committing code I believe this raises you to level of a repo Should there be two badges? Most teams don't have multiple badges. You've raised a great question! |
|
I added author information to GALLERY.md as an early form of recognition: #30 |
…ma (#23) Solves the Blueprint parsing problem as follows: * JSON Schema is the source of truth for the Blueprint data structure * Model classes are generated from JSON Schema * Input Validation is done against the JSON Schema * Mapping validated input into model instances is indirectly done based on the JSON Schema ## Summary of the approach We use [Janephp](https://github.com/janephp/janephp/) to infer the PHP model class structure from the JSON schema We then use Jane's output to generate PHP code using [Nette PHP generator](https://github.com/nette/php-generator): * Model classes * Interfaces for groups of related classes: `StepDefinitionInterface`, `ResourceDefinitionInterface`. * Interface resolution map for the [JsonMapper library](https://jsonmapper.net/). * PHP docstrings with more accurate types than Jane to guide the mapping process From there, the data pipeline looks as follows: 1. Parse raw JSON 2. Validate it with Opis 3. Map it into PHP models using JsonMapper Or, if you're consuming the PHP API directly: 1. Create Model instances 2. Validate them with Opis ## Remaining work - [ ] Solve merge conflicts ## Rationale Parsing and mapping JSON [in TypeScript is a simple problem, but in PHP it's surprisingly involved](WordPress/blueprints#13 (comment)). This PR combines three previously explored approaches into a single pipeline: * WordPress/blueprints#17 * WordPress/blueprints#19 * WordPress/blueprints#21
Props for contributing to WordPress is a new concept that enables those who want to contribute an easy way to get started.
Maybe someone is just getting started and don't fully understand Pull Requests in GitHub, maybe they have that one really great idea they want to share, but don't know how to build it.
Let's figure out a way for them to get involved with the Blueprints Community and give credit for their contributions.
From Making WordPress post
I'd like to introduce a proposal to give credit in some way to those who contribute to the Blueprints Community!
Existing limitations
The Props Bot is currently only available in the WordPress organization? How to expand props to the Blueprints Community?
Feedback is much appreciate as always 👍
The text was updated successfully, but these errors were encountered: