-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates from running script #11
Conversation
I'm seeing a difference in counts on this one, would @elibud to double check the changes look ok as maybe my eyes are crooked tonight. |
There were 2 or 3 (iirc) people who consented a "second" time with this run, so we are recording the comment as "handled" but not adding a "new" consent to the count. There was also a comment from someone granting consent ( Sorry I forgot to mention that in the issue description. I didn't think about how those would make the count appear off. |
@mchowning to be as accurate and precise as possible with |
Updated with a new run of the script.
👍 I thought maybe this was just a case where they changed their username, but it doesn't appear to be the case (both users exist separately), so I think that you're right that I need to reach out to the user and ask them to approve from the other account. I left a comments on the issue asking both cristainraiber and fritz-c to follow-up with the account that authored the contributions. |
I'll also make note tomorrow to ping them outside of GitHub to alert them to the same need in case they are ignoring that GH issue. |
👍 Is there anything else we need to do to merge this @jeffpaul ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll work to get confirmed approval from alternate/preferred handles for these folks tomorrow
I updated these names on the Google Sheet as having consented as well.