Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates from running script #11

Merged
merged 2 commits into from
Jul 6, 2021
Merged

Updates from running script #11

merged 2 commits into from
Jul 6, 2021

Conversation

mchowning
Copy link
Collaborator

I updated these names on the Google Sheet as having consented as well.

@mchowning mchowning requested review from jeffpaul and elibud July 1, 2021 21:05
@jeffpaul
Copy link
Member

jeffpaul commented Jul 2, 2021

I'm seeing a difference in counts on this one, would @elibud to double check the changes look ok as maybe my eyes are crooked tonight.

@mchowning
Copy link
Collaborator Author

There were 2 or 3 (iirc) people who consented a "second" time with this run, so we are recording the comment as "handled" but not adding a "new" consent to the count.

There was also a comment from someone granting consent (cristianraiber) who the script indicated was not a contributor. I have written that down as something I need to follow up on (probably just need to ask them to confirm that they are the same as cristian-raiber, but I wanted to see if there was a way for me to confirm that without bugging them again).

Sorry I forgot to mention that in the issue description. I didn't think about how those would make the count appear off.

@jeffpaul
Copy link
Member

jeffpaul commented Jul 2, 2021

@mchowning to be as accurate and precise as possible with cristianraiber we will probably want to check the contributor details as if its cristian-raiber that's the correct account then we ideally get them to approve from that account.

@mchowning
Copy link
Collaborator Author

mchowning commented Jul 6, 2021

Updated with a new run of the script.

to be as accurate and precise as possible with cristianraiber we will probably want to check the contributor details as if its cristian-raiber that's the correct account then we ideally get them to approve from that account.

👍 I thought maybe this was just a case where they changed their username, but it doesn't appear to be the case (both users exist separately), so I think that you're right that I need to reach out to the user and ask them to approve from the other account. I left a comments on the issue asking both cristainraiber and fritz-c to follow-up with the account that authored the contributions.

@jeffpaul
Copy link
Member

jeffpaul commented Jul 6, 2021

I'll also make note tomorrow to ping them outside of GitHub to alert them to the same need in case they are ignoring that GH issue.

@mchowning
Copy link
Collaborator Author

I'll also make note tomorrow to ping them outside of GitHub to alert them to the same need in case they are ignoring that GH issue.

👍

Is there anything else we need to do to merge this @jeffpaul ?

Copy link
Member

@jeffpaul jeffpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll work to get confirmed approval from alternate/preferred handles for these folks tomorrow

@jeffpaul jeffpaul merged commit e432e27 into trunk Jul 6, 2021
@jeffpaul jeffpaul deleted the update-from-running-script branch July 6, 2021 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants