Make deferredRendering optional by providing a good default (false).

WordPress · Dec 21, 2023 · 2122329 · 2122329
1 parent 90c9ab3
commit 2122329
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 3 deletions.
diff --git a/packages/dataviews/README.md b/packages/dataviews/README.md
@@ -235,7 +235,7 @@ Array of operations that can be performed upon each record. Each action is an ob
 - `getItemId`: function that receives an item and returns an unique identifier for it. By default, it uses the `id` of the item as unique identifier. If it's not, the consumer should provide their own.
 - `isLoading`: whether the data is loading. `false` by default.
 - `supportedLayouts`: array of layouts supported. By default, all are: `table`, `grid`, `list`.
-- `deferredRendering`: whether the items should be rendered asynchronously. Required.
+- `deferredRendering`: whether the items should be rendered asynchronously. Useful when there's a field that takes a lot of time (e.g.: previews). `false` by default.
 - `onSelectionChange`: callback that returns the selected items. So far, only the `list` view implements this.
 
 ## Contributing to this package

diff --git a/packages/dataviews/src/dataviews.js b/packages/dataviews/src/dataviews.js
@@ -31,7 +31,7 @@ export default function DataViews( {
 	paginationInfo,
 	supportedLayouts,
 	onSelectionChange,
-	deferredRendering,
+	deferredRendering = false,
 } ) {
 	const [ selection, setSelection ] = useState( [] );
 

diff --git a/packages/edit-site/src/components/page-pages/index.js b/packages/edit-site/src/components/page-pages/index.js
@@ -342,7 +342,6 @@ export default function PagePages() {
 					view={ view }
 					onChangeView={ onChangeView }
 					onSelectionChange={ onSelectionChange }
-					deferredRendering={ false }
 				/>
 			</Page>
 			{ view.type === LAYOUT_LIST && (