Disable percentage units for Spacer

WordPress · Dec 6, 2021 · 36b8192 · 36b8192
1 parent c63fe49
commit 36b8192
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 111 deletions.
diff --git a/packages/block-library/src/common.scss b/packages/block-library/src/common.scss
diff --git a/packages/block-library/src/spacer/controls.js b/packages/block-library/src/spacer/controls.js
@@ -37,8 +37,15 @@ function DimensionInput( {
 	const inputId = `block-spacer-height-input-${ instanceId }`;
 	const isPx = unit === 'px';
 
+	// In most contexts the spacer size cannot meaningfully be set to a
+	// percentage, since this is relative to the parent container. This
+	// unit is disabled from the UI.
+	const availableUnitSettings = useSetting( 'spacing.units' ).filter(
+		( availableUnit ) => availableUnit !== '%'
+	);
+
 	const units = useCustomUnits( {
-		availableUnits: useSetting( 'spacing.units' ) || [
+		availableUnits: availableUnitSettings || [
 			'px',
 			'em',
 			'rem',