SiteEditor: Optimize BackToPageNotification component (#56102)

WordPress · Nov 14, 2023 · 560c38d · 560c38d
1 parent 8c29767
commit 560c38d
Showing 1 changed file with 4 additions and 15 deletions.
diff --git a/packages/edit-site/src/components/page-content-focus-manager/back-to-page-notification.js b/packages/edit-site/src/components/page-content-focus-manager/back-to-page-notification.js
@@ -25,27 +25,19 @@ export default function BackToPageNotification() {
  * switches from focusing on editing page content to editing a template.
  */
 export function useBackToPageNotification() {
-	const { isPage, hasPageContentFocus } = useSelect(
-		( select ) => ( {
-			isPage: select( editSiteStore ).isPage(),
-			hasPageContentFocus: select( editSiteStore ).hasPageContentFocus(),
-		} ),
+	const hasPageContentFocus = useSelect(
+		( select ) => select( editSiteStore ).hasPageContentFocus(),
 		[]
 	);
+	const { isPage } = useSelect( editSiteStore );
 
 	const alreadySeen = useRef( false );
-	const prevHasPageContentFocus = useRef( false );
 
 	const { createInfoNotice } = useDispatch( noticesStore );
 	const { setHasPageContentFocus } = useDispatch( editSiteStore );
 
 	useEffect( () => {
-		if (
-			! alreadySeen.current &&
-			isPage &&
-			prevHasPageContentFocus.current &&
-			! hasPageContentFocus
-		) {
+		if ( isPage() && ! alreadySeen.current && ! hasPageContentFocus ) {
 			createInfoNotice( __( 'You are editing a template.' ), {
 				isDismissible: true,
 				type: 'snackbar',
@@ -58,11 +50,8 @@ export function useBackToPageNotification() {
 			} );
 			alreadySeen.current = true;
 		}
-		prevHasPageContentFocus.current = hasPageContentFocus;
 	}, [
-		alreadySeen,
 		isPage,
-		prevHasPageContentFocus,
 		hasPageContentFocus,
 		createInfoNotice,
 		setHasPageContentFocus,