Skip to content

Commit

Permalink
Equalize modal internal padding (#49890)
Browse files Browse the repository at this point in the history
  • Loading branch information
@jameskoster
jameskoster committed Apr 18, 2023
1 parent 803fc7d commit 8be5532
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
2 changes: 2 additions & 0 deletions packages/components/CHANGELOG.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,10 @@
### Enhancements

- `TreeGrid`: Modify keyboard navigation code to use a data-expanded attribute if aria-expanded is to be controlled outside of the TreeGrid component ([#48461](https://github.com/WordPress/gutenberg/pull/48461)).
- `Modal`: Equalize internal spacing ([#49890](https://github.com/WordPress/gutenberg/pull/49890)).
- `Modal`: Increased border radius ([#49870](https://github.com/WordPress/gutenberg/pull/49870)).


### Documentation

- `Autocomplete`: Add heading and fix type for `onReplace` in README. ([#49798](https://github.com/WordPress/gutenberg/pull/49798)).
Expand Down
6 changes: 3 additions & 3 deletions packages/components/src/modal/style.scss
View file
Original file line number Diff line number Diff line change
Expand Up @@ -64,12 +64,12 @@
.components-modal__header {
box-sizing: border-box;
border-bottom: $border-width solid transparent;
padding: 0 $grid-unit-40;
padding: $grid-unit-30 $grid-unit-40 $grid-unit-15;
display: flex;
flex-direction: row;
justify-content: space-between;
align-items: center;
height: $header-height + $grid-unit-20;
height: $header-height + $grid-unit-15;
width: 100%;
z-index: z-index(".components-modal__header");
position: absolute;
Expand Down Expand Up @@ -121,7 +121,7 @@
// Modal contents.
.components-modal__content {
flex: 1;
margin-top: $header-height + $grid-unit-20;
margin-top: $header-height + $grid-unit-15;
padding: 0 $grid-unit-40 $grid-unit-40;
overflow: auto;

Expand Down

1 comment on commit 8be5532

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flaky tests detected in 8be5532.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4733771745
📝 Reported issues:

Please sign in to comment.