Skip to content

Commit

Permalink
Rename var for consistency
Browse files Browse the repository at this point in the history
  • Loading branch information
getdave committed Sep 29, 2023
1 parent 02ee8a2 commit 9bd8998
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 9 deletions.
2 changes: 1 addition & 1 deletion packages/block-library/src/navigation-link/link-ui.js
Expand Up @@ -47,7 +47,7 @@ export function getSuggestionsQuery( type, kind ) {
return {
// for custom link which has no type
// always show pages as initial suggestions
initialSuggestionsOptions: {
initialSuggestionsSearchOptions: {
type: 'post',
subtype: 'page',
perPage: 20,
Expand Down
Expand Up @@ -85,7 +85,7 @@ const fetchLinkSuggestions = async (
) => {
const {
isInitialSuggestions = false,
initialSuggestionsOptions = undefined,
initialSuggestionsSearchOptions = undefined,
} = searchOptions;

const { disablePostFormats = false } = settings;
Expand All @@ -100,11 +100,11 @@ const fetchLinkSuggestions = async (
/** @type {Promise<WPLinkSearchResult>[]} */
const queries = [];

if ( isInitialSuggestions && initialSuggestionsOptions ) {
type = initialSuggestionsOptions.type || type;
subtype = initialSuggestionsOptions.subtype || subtype;
page = initialSuggestionsOptions.page || page;
perPage = initialSuggestionsOptions.perPage || perPage;
if ( isInitialSuggestions && initialSuggestionsSearchOptions ) {
type = initialSuggestionsSearchOptions.type || type;
subtype = initialSuggestionsSearchOptions.subtype || subtype;
page = initialSuggestionsSearchOptions.page || page;
perPage = initialSuggestionsSearchOptions.perPage || perPage;
}

if ( ! type || type === 'post' ) {
Expand Down
Expand Up @@ -256,7 +256,7 @@ describe( 'fetchLinkSuggestions', () => {
subtype: 'category',
page: 11,
isInitialSuggestions: true,
initialSuggestionsOptions: {
initialSuggestionsSearchOptions: {
type: 'post',
subtype: 'page',
perPage: 20,
Expand All @@ -282,7 +282,7 @@ describe( 'fetchLinkSuggestions', () => {
page: 11,
perPage: 20,
isInitialSuggestions: true,
initialSuggestionsOptions: {
initialSuggestionsSearchOptions: {
// intentionally missing.
// expected to default to those from the main search options.
},
Expand Down

0 comments on commit 9bd8998

Please sign in to comment.