minimal node and npm upgrade (#53426)

* minimal node and npm upgrade * fix some ts errors * The package-lock.json commit --------- Co-authored-by: Jorge Costa <jorge.costa@developer.pt> Co-authored-by: Noah Allen <noahtallen@gmail.com> Co-authored-by: Kai Has <hi@kaihao.dev>
WordPress · Aug 9, 2023 · a3bef32 · a3bef32
1 parent 0ebcee8
commit a3bef32
Show file tree

Hide file tree

Showing 16 changed files with 91,941 additions and 42,520 deletions.
diff --git a/.github/workflows/create-block.yml b/.github/workflows/create-block.yml
@@ -20,7 +20,7 @@ jobs:
         strategy:
             fail-fast: false
             matrix:
-                node: ['14']
+                node: ['16']
                 os: [macos-latest, ubuntu-latest, windows-latest]
 
         steps:

diff --git a/.github/workflows/end2end-test.yml b/.github/workflows/end2end-test.yml
@@ -41,8 +41,8 @@ jobs:
 
             - name: Running the tests
               run: |
-                  $( npm bin )/wp-scripts test-e2e --config=./packages/e2e-tests/jest.config.js --listTests > ~/.jest-e2e-tests
-                  $( npm bin )/wp-scripts test-e2e --config=./packages/e2e-tests/jest.config.js --cacheDirectory="$HOME/.jest-cache" --runTestsByPath $( awk 'NR % ${{ matrix.totalParts }} == ${{ matrix.part }} - 1' < ~/.jest-e2e-tests )
+                  npx wp-scripts test-e2e --config=./packages/e2e-tests/jest.config.js --listTests > ~/.jest-e2e-tests
+                  npx wp-scripts test-e2e --config=./packages/e2e-tests/jest.config.js --cacheDirectory="$HOME/.jest-cache" --runTestsByPath $( awk 'NR % ${{ matrix.totalParts }} == ${{ matrix.part }} - 1' < ~/.jest-e2e-tests )
 
             - name: Archive debug artifacts (screenshots, HTML snapshots)
               uses: actions/upload-artifact@0b7f8abb1508181956e8e162db84b466c27e18ce # v3.1.2

diff --git a/.github/workflows/performance.yml b/.github/workflows/performance.yml
@@ -37,6 +37,13 @@ jobs:
             - name: Setup Node.js and install dependencies
               uses: ./.github/setup-node
 
+            - name: Install NVM
+              run: |
+                  curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.39.1/install.sh | bash
+                  export NVM_DIR="$HOME/.nvm"
+                  [ -s "$NVM_DIR/nvm.sh" ] && \. "$NVM_DIR/nvm.sh"
+                  nvm -v
+
             - name: Compare performance with trunk
               if: github.event_name == 'pull_request'
               run: ./bin/plugin/cli.js perf $GITHUB_SHA trunk --tests-branch $GITHUB_SHA

diff --git a/.github/workflows/pull-request-automation.yml b/.github/workflows/pull-request-automation.yml
@@ -10,7 +10,7 @@ jobs:
         if: ${{ github.repository == 'WordPress/gutenberg' }}
         strategy:
             matrix:
-                node: ['14']
+                node: ['16']
 
         steps:
             # Checkout defaults to using the branch which triggered the event, which

diff --git a/.github/workflows/unit-test.yml b/.github/workflows/unit-test.yml
@@ -28,7 +28,7 @@ jobs:
         strategy:
             fail-fast: false
             matrix:
-                node: ['14']
+                node: ['16']
 
         steps:
             - uses: actions/checkout@c85c95e3d7251135ab7dc9ce3241c5835cc595a9 # v3.5.3

diff --git a/.npmrc b/.npmrc
@@ -1,2 +1,3 @@
 save-exact = true
 engine-strict = true
+legacy-peer-deps = true
diff --git a/.nvmrc b/.nvmrc
@@ -1 +1 @@
-14
+16
diff --git a/bin/plugin/commands/performance.js b/bin/plugin/commands/performance.js
@@ -285,7 +285,7 @@ async function runPerformanceTests( branches, options ) {
 
 	log( '    >> Installing dependencies and building packages' );
 	await runShellScript(
-		'npm ci && node ./bin/packages/build.js',
+		'bash -c "source $HOME/.nvm/nvm.sh && nvm install && npm ci && node ./bin/packages/build.js"',
 		performanceTestDirectory
 	);
 	log( '    >> Creating the environment folders' );
@@ -321,7 +321,7 @@ async function runPerformanceTests( branches, options ) {
 
 		log( `        >> Building the ${ fancyBranch } branch` );
 		await runShellScript(
-			'npm ci && npm run prebuild:packages && node ./bin/packages/build.js && npx wp-scripts build',
+			'bash -c "source $HOME/.nvm/nvm.sh && nvm install && npm ci && npm run prebuild:packages && node ./bin/packages/build.js && npx wp-scripts build"',
 			buildPath
 		);
 

diff --git a/bin/validate-package-lock.js b/bin/validate-package-lock.js
@@ -20,7 +20,7 @@ const { red, yellow } = require( 'chalk' );
 // @ts-ignore
 const packageLock = require( '../package-lock' );
 
-const dependencies = Object.entries( packageLock.dependencies );
+const dependencies = Object.entries( packageLock.packages );
 for ( const [ name, dependency ] of dependencies ) {
 	if ( dependency.resolved === false ) {
 		console.log(