Try a different approach for styling movers

WordPress · Jan 16, 2018 · adbdbb7 · adbdbb7
1 parent db533fa
commit adbdbb7
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 9 deletions.
diff --git a/components/dashicon/index.js b/components/dashicon/index.js
@@ -857,6 +857,7 @@ export default class Dashicon extends wp.element.Component {
 
 		return (
 			<svg
+				tabindex="-1"
 				aria-hidden
 				role="img"
 				focusable="false"

diff --git a/editor/assets/stylesheets/_mixins.scss b/editor/assets/stylesheets/_mixins.scss
@@ -121,31 +121,25 @@ $float-margin: calc( 50% - #{ $visual-editor-max-width-padding / 2 } );
 }
 
 @mixin button-style__hover {
-	color: $dark-gray-900;	// previously $blue-medium-500
+	color: $dark-gray-900;
 	box-shadow: inset 0 0 0 1px $light-gray-500, inset 0 0 0 2px $white;
 }
 
 @mixin button-style__focus-active() {
 	outline: none;
 	color: $dark-gray-900;
-	//box-shadow: inset 0 0 0 1px $dark-gray-500, inset 0 0 0 2px $white;
-	//background: $light-gray-300;
 	box-shadow: inset 0 0 0 1px $dark-gray-300, inset 0 0 0 2px $white;
 }
 
 @mixin button-style__active() {
 	outline: none;
 	color: $dark-gray-900;
-	//box-shadow: inset 0 0 0 1px $dark-gray-500, inset 0 0 0 2px $white;
-	//background: $light-gray-300;
 	box-shadow: inset 0 0 0 1px $dark-gray-400, inset 0 0 0 2px $white, 0 1px 1px rgba( $dark-gray-900, .2 );
 }
 
 @mixin tab-style__focus-active() {
 	outline: none;
 	color: $dark-gray-900;
-	//box-shadow: 0 0 0 1px $dark-gray-500;
-	//background: $light-gray-300;
 	box-shadow: inset 0 0 0 1px $dark-gray-300;
 }
 

diff --git a/editor/components/block-mover/style.scss b/editor/components/block-mover/style.scss
@@ -16,11 +16,34 @@
 		pointer-events: none;
 	}
 
+	&:first-child {
+		margin-bottom: 4px;
+	}
+
+	// unstyle inherited icon button styles
+	&:not(:disabled):hover,
+  	&:not(:disabled):active,
+	&:not(:disabled):focus {
+		box-shadow: none;
+		color: inherit;
+	}
+
+	// apply styles to SVG directly
 	.dashicon {
 		display: block;
+		position: relative; // Fixing the Safari bug for `<button>`s overflow
+		border-radius: 50%;
 	}
 
-	&:first-child {
-		margin-bottom: 4px;
+	&:not(:disabled):hover .dashicon {
+		@include button-style__hover;
+	}
+
+	&:not(:disabled):active .dashicon {
+		@include button-style__active;
+	}
+
+	&:not(:disabled):focus .dashicon {
+		@include button-style__focus-active;
 	}
 }