Block Directory: Optimize DownloadableBlocksPanel (#47679)

WordPress · Feb 2, 2023 · b0275ae · b0275ae · github-actions · Feb 2, 2023
1 parent 1929bdc
commit b0275ae
Showing 1 changed file with 15 additions and 2 deletions.
diff --git a/packages/block-directory/src/components/downloadable-blocks-panel/index.js b/packages/block-directory/src/components/downloadable-blocks-panel/index.js
@@ -16,6 +16,8 @@ import DownloadableBlocksInserterPanel from './inserter-panel';
 import DownloadableBlocksNoResults from './no-results';
 import { store as blockDirectoryStore } from '../../store';
 
+const EMPTY_ARRAY = [];
+
 function DownloadableBlocksPanel( {
 	downloadableItems,
 	onSelect,
@@ -81,14 +83,25 @@ export default compose( [
 		);
 
 		function getInstallableBlocks( term ) {
-			return getDownloadableBlocks( term ).filter( ( block ) =>
+			const downloadableBlocks = getDownloadableBlocks( term );
+			const installableBlocks = downloadableBlocks.filter( ( block ) =>
 				canInsertBlockType( block, rootClientId, true )
 			);
+
+			if ( downloadableBlocks.length === installableBlocks.length ) {
+				return downloadableBlocks;
+			}
+			return installableBlocks;
 		}
 
-		const downloadableItems = hasPermission
+		let downloadableItems = hasPermission
 			? getInstallableBlocks( filterValue )
 			: [];
+
+		if ( downloadableItems.length === 0 ) {
+			downloadableItems = EMPTY_ARRAY;
+		}
+
 		const isLoading = isRequestingDownloadableBlocks( filterValue );
 
 		return {