Navigation component: Fix item handling onClick twice (#33286)

WordPress · Jul 19, 2021 · b605256 · b605256
1 parent d40b5a1
commit b605256
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/packages/components/src/navigation/item/index.js b/packages/components/src/navigation/item/index.js
@@ -63,14 +63,15 @@ export default function NavigationItem( props ) {
 		onClick( event );
 	};
 	const icon = isRTL() ? chevronLeft : chevronRight;
-	const baseProps = isText
+	const baseProps = children ? props : { ...props, onClick: undefined };
+	const itemProps = isText
 		? restProps
 		: { as: Button, href, onClick: onItemClick, ...restProps };
 
 	return (
-		<NavigationItemBase { ...props } className={ classes }>
+		<NavigationItemBase { ...baseProps } className={ classes }>
 			{ children || (
-				<ItemUI { ...baseProps }>
+				<ItemUI { ...itemProps }>
 					<NavigationItemBaseContent
 						title={ title }
 						badge={ badge }