Why is the text color being hard-coded to white here? #43539
-
|
I've just had an issue of Buttons with the 'Fill' style having their text color overridden by this snippet here, what's the purpose of it? It appears to take precedence over the text color which is set on |
Beta Was this translation helpful? Give feedback.
Replies: 1 comment 1 reply
-
|
I believe the color was necessary to ensure contrast against the default dark gray background that was also provided. However it seems like those colors are now provided by a back-compat theme library, and can be removed here. I've created a PR to do that #43553 — but would appreciate input there. |
Beta Was this translation helpful? Give feedback.
-
|
This has been fixed. |
Beta Was this translation helpful? Give feedback.
I believe the color was necessary to ensure contrast against the default dark gray background that was also provided.
However it seems like those colors are now provided by a back-compat theme library, and can be removed here. I've created a PR to do that #43553 — but would appreciate input there.