Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Press This quoted content is partially lost when converting to blocks #10456

Closed
Clorith opened this issue Oct 9, 2018 · 1 comment · Fixed by #12122
Closed

Press This quoted content is partially lost when converting to blocks #10456

Clorith opened this issue Oct 9, 2018 · 1 comment · Fixed by #12122
Labels
Backwards Compatibility Issues or PRs that impact backwards compatability [Feature] Block Conversion Block transforms from one block to another [Type] Bug An existing feature does not function as intended

Comments

@Clorith
Copy link
Member

Clorith commented Oct 9, 2018

When viewing content from a press This post of an image or similar, the content is made as an image, linked to the original source, with a blockquote including an excerpt of any text from the page you are pressing on.

When converting to blocks, the excerpt is converted to a blockquote block, but the media item is stripped out.

The classic data from Press This:

<blockquote><a href="http://io9.gizmodo.com/saturn-dominates-dione-in-this-striking-new-photo-from-1729602344"><img class="alignnone size-full" src="https://www.clorith.net/wp-content/uploads/2015/12/1423360911693531534.png" alt="" /></a>Saturn’s satellite Dione is less than half the size of our moon, and it orbits a planet which features a radius nine times that of Earth. It’s a stark contrast in size that’s beautifully conveyed in a picture recently captured by the Cassini space probe.</blockquote>
Source: <em><a href="http://io9.gizmodo.com/saturn-dominates-dione-in-this-striking-new-photo-from-1729602344">Saturn Dominates Dione in this Striking New Photo From NASA</a></em>

Screencap
press-this-loss

Versions

  • WordPress 4.9.8
  • Gutenberg 3.9.0
@danielbachhuber danielbachhuber added [Type] Bug An existing feature does not function as intended Backwards Compatibility Issues or PRs that impact backwards compatability labels Oct 10, 2018
@danielbachhuber danielbachhuber added this to the WordPress 5.0 milestone Oct 10, 2018
@mtias mtias added the [Feature] Block Conversion Block transforms from one block to another label Oct 17, 2018
@mtias
Copy link
Member

mtias commented Nov 17, 2018

This particular issue is constrained by the Quote block not supporting other blocks within. It should be turned into an InnerBlocks area with support for paragraph, list, image, and maybe a few others. The main blocker has been UI polish on nested structures, which is almost there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backwards Compatibility Issues or PRs that impact backwards compatability [Feature] Block Conversion Block transforms from one block to another [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants