Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library of Blocks: ensure consistency in patterns used #1205

Closed
mtias opened this issue Jun 15, 2017 · 1 comment
Closed

Library of Blocks: ensure consistency in patterns used #1205

mtias opened this issue Jun 15, 2017 · 1 comment
Assignees
Labels
[Feature] Block API API that allows to express the block paradigm. [Feature] Blocks Overall functionality of blocks [Type] Developer Documentation Documentation for developers
Projects
Milestone

Comments

@mtias
Copy link
Member

mtias commented Jun 15, 2017

As we approach release and merge windows, we need to make sure our core blocks are written in the way we want other blocks to be written. That means consistent expression (i.e. array of return values in edit functions, accessing globals vs imports, CSS scope and classes, declaration of toolbar controls, etc).

@youknowriad
Copy link
Contributor

@mtias Should we close this issue? It's not an actionable item

@mtias mtias closed this as completed Aug 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Block API API that allows to express the block paradigm. [Feature] Blocks Overall functionality of blocks [Type] Developer Documentation Documentation for developers
Projects
No open projects
Blocks
In Development
Development

No branches or pull requests

3 participants