Blocks: Dropping the controls property from blocks #1262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
the
Framework
BE-Webdesign
approved these changes
Jun 21, 2017
There was a problem hiding this comment.
Looks Great Riad! The gallery controls as well as the quote controls still work, so I do not believe any regressions occurred. Been a while since I looked at the blocks, and I like the new pattern where the control views are defined in the block instead of higher up.
BE-Webdesign
previously requested changes
Jun 21, 2017
blocks/library/gallery/index.js
Outdated
| return [ | ||
| controls, | ||
| focus && images.length > 1 && ( | ||
| <InspectorControls> |
There was a problem hiding this comment.
This will need a key attribute set for it I believe.
youknowriad
force-pushed
the
update/drop-controls-property
branch
from
ca0517f
to
317827c
Compare
|
Thanks for the review @BE-Webdesign |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I'm updating all the blocks to use
BlockControlsineditinstead of thecontrolsproperty.related #1205