Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove option to use classic editor (unless classic editor plugin enabled) #12888

Closed
adamsilverstein opened this issue Dec 14, 2018 · 5 comments
Labels
General Interface Parts of the UI which don't fall neatly under other labels. [Type] Bug An existing feature does not function as intended

Comments

@adamsilverstein
Copy link
Member

Describe the bug
After upgrading to WordPress 5.0 and installing the plugin, I am presented with the option to edit content in the classic editor even though I don't have the classic editor plugin installed.

Related: #11015

@designsimply
Copy link
Member

Tested and confirmed that I see the option to edit content in the classic editor withe the Gutenberg 4.7.0 plugin installed on WordPress 5.0.1.

If I click the "Classic Editor" link on the Posts or Pages screen and then click Continue, I see a blank screen and the following error in the console:

TypeError: window._wpLoadBlockEditor is undefined
post.php:1731:1

screen shot 2018-12-16 at 2 02 39 pm
Seen at https://testingallthetime.com/wp-admin/post.php?post=47&action=edit&classic-editor running WordPress 5.0.1 and Gutenberg 4.7.0 using Firefox 63.0.3 on macOS 10.13.6.

@designsimply designsimply added [Type] Bug An existing feature does not function as intended General Interface Parts of the UI which don't fall neatly under other labels. labels Dec 16, 2018
@nfmohit
Copy link
Member

nfmohit commented Jan 6, 2019

Submitted #13217 addressing this issue.

@aduth
Copy link
Member

aduth commented Jan 7, 2019

This code should probably be removed altogether.

I'd started down this path on Friday, but there's a fair bit of the metabox code which makes assumption about ?classic-editor. In fact, most of this code ought to probably also be removed, with an assumption that it be provided already through WP 5.0+ (set as a new minimum required version for the Gutenberg plugin).

@youknowriad
Copy link
Contributor

I think this one done recently right @aduth ?

@aduth
Copy link
Member

aduth commented Feb 6, 2019

It's partially resolved by #13459, with final pieces slated to be removed by #13544 (approved).

I'll add a closing reference accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
General Interface Parts of the UI which don't fall neatly under other labels. [Type] Bug An existing feature does not function as intended
Projects
None yet
5 participants