Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation block in wp-admin #13206

Closed
mapk opened this issue Jan 5, 2019 · 6 comments
Closed

Navigation block in wp-admin #13206

mapk opened this issue Jan 5, 2019 · 6 comments
Assignees
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). General Interface Parts of the UI which don't fall neatly under other labels. Needs Design Needs design efforts.
Projects
Milestone

Comments

@mapk
Copy link
Contributor

mapk commented Jan 5, 2019

As noted in the Phase 2 post:

The Navigation block will be accessed from within wp-admin menu screen. Take a look at the mockup below which was presented in State of the Word 2018.

menus-new

We'll need to determine if these mockups are the right solution. Let's dig in!

@mapk mapk added General Interface Parts of the UI which don't fall neatly under other labels. Needs Design Needs design efforts. labels Jan 5, 2019
@mapk mapk added this to the Future: Phase 2 milestone Jan 5, 2019
@mapk mapk self-assigned this Jan 5, 2019
@mapk mapk added this to To do in Phase 2 design Jan 5, 2019
@ZebulanStanphill
Copy link
Member

If the wp-admin menu editor is to remain non-visual, then I think the little plus icon should have some text displayed next to it saying "Add menu item" (or something similar) for accessibility reasons. No reason to leave the button unlabeled when there is plenty of space to label it and no reason to keep it small like in a standard block/post editor where you're trying not to obscure a near-preview of the front-end. In this mockup, I think the plus icon looks a bit out-of-place, given the style of the menu item metaboxes/widgets/whatever-you-call-them.

If the wp-admin menu editor is becoming more WYSIWYG, however, then that's a whole other story.

@karmatosed karmatosed moved this from To do to In progress in Phase 2 design Jan 5, 2019
@afercia
Copy link
Contributor

afercia commented Jan 14, 2019

Not clear to me what happens to the menu items expandable "panels". Will they be re-implemented in React or stay as now?

There's a lot of visually hidden information there for screen reader users, things like:

aria-label="Hello world!. Menu item 2 of 2."

aria-label="Page Image Alignment. Sub item number 2 under Hello world!."

Also, the only way to reorder items when using a keyboard is by using the controls within the panels:

screenshot 2019-01-14 at 16 56 14

@celloexpressions
Copy link

Why are we putting resources into the wp-admin version of menus? It seems like this would be a good opportunity to finally deprecate this screen entirely in favor of the customizer. We have taken several steps in that direction in recent years. See https://make.wordpress.org/core/2015/06/03/feature-plugin-merge-proposal-menu-customizer/ for the original formal proposal to do so. And also, numerous other updates over the years at https://make.wordpress.org/core/?s=menu+customizer.

Menus in the customizer have already been rewritten into a JavaScript-based and scalable experience. The updates there should be able to extend that existing API rather than doing a complete rewrite, unlike in the menus screen. The wp-admin menus screen largely exists as a no-js fallback at this point, which likely wouldn't be able to be maintained with blocks.

Focusing on one version of this interface, preferably the more-modern one, which already supports instant live preview, would allow more resources to ensure that this "blockification" also improves the longstanding issues with menu accessibility and extensibility.

@afercia
Copy link
Contributor

afercia commented Jan 18, 2019

The customizer is not fully accessible. The admin menus screen is the only place where persons with accessibility needs have a chance to build menus without having to face big accessibility barriers.

@afercia afercia added the [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). label Jan 19, 2019
@karmatosed karmatosed added this to To Do in Phase 2 via automation Jan 31, 2019
@karmatosed karmatosed removed this from In progress in Phase 2 design Jan 31, 2019
@karmatosed karmatosed moved this from To Do to Navigation in Phase 2 Jan 31, 2019
@celloexpressions
Copy link

This would be a great opportunity to re-imagine the customizer UI structure to be fully accessible. That way, menus and widgets can be fully accessible without requiring maintenance of a separate accessibility mode or with a separate screen. And the other features that are only available in the customizer would get the same accessibility improvements.

If the resources that would otherwise be allocated to a new version of menus (and widgets) in wp-admin were instead focused on fixing accessibility issues in the customizer (likely via some fundamental markup changes), users would benefit from the improved accessibility for all of the functionality in the customizer. And core would no longer need to spend time maintaining (or neglecting) multiple interfaces for the same feature.

@karmatosed karmatosed removed this from Navigation in Phase 2 Jul 16, 2019
@karmatosed karmatosed added this to To do in Blocks Jul 16, 2019
@karmatosed
Copy link
Member

Closing this as we are now exploring here: #19170

Blocks automation moved this from To Do to Done Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). General Interface Parts of the UI which don't fall neatly under other labels. Needs Design Needs design efforts.
Projects
Blocks
  
Done
Development

No branches or pull requests

5 participants