New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation block in wp-admin #13206

Open
mapk opened this Issue Jan 5, 2019 · 4 comments

Comments

@mapk
Copy link
Contributor

mapk commented Jan 5, 2019

As noted in the Phase 2 post:

The Navigation block will be accessed from within wp-admin menu screen. Take a look at the mockup below which was presented in State of the Word 2018.

menus-new

We'll need to determine if these mockups are the right solution. Let's dig in!

@mapk mapk added this to the Future: Phase 2 milestone Jan 5, 2019

@mapk mapk self-assigned this Jan 5, 2019

@mapk mapk added this to To do in Phase 2 design Jan 5, 2019

@ZebulanStanphill

This comment has been minimized.

Copy link
Contributor

ZebulanStanphill commented Jan 5, 2019

If the wp-admin menu editor is to remain non-visual, then I think the little plus icon should have some text displayed next to it saying "Add menu item" (or something similar) for accessibility reasons. No reason to leave the button unlabeled when there is plenty of space to label it and no reason to keep it small like in a standard block/post editor where you're trying not to obscure a near-preview of the front-end. In this mockup, I think the plus icon looks a bit out-of-place, given the style of the menu item metaboxes/widgets/whatever-you-call-them.

If the wp-admin menu editor is becoming more WYSIWYG, however, then that's a whole other story.

@karmatosed karmatosed moved this from To do to In progress in Phase 2 design Jan 5, 2019

@afercia

This comment has been minimized.

Copy link
Contributor

afercia commented Jan 14, 2019

Not clear to me what happens to the menu items expandable "panels". Will they be re-implemented in React or stay as now?

There's a lot of visually hidden information there for screen reader users, things like:

aria-label="Hello world!. Menu item 2 of 2."

aria-label="Page Image Alignment. Sub item number 2 under Hello world!."

Also, the only way to reorder items when using a keyboard is by using the controls within the panels:

screenshot 2019-01-14 at 16 56 14

@celloexpressions

This comment has been minimized.

Copy link

celloexpressions commented Jan 18, 2019

Why are we putting resources into the wp-admin version of menus? It seems like this would be a good opportunity to finally deprecate this screen entirely in favor of the customizer. We have taken several steps in that direction in recent years. See https://make.wordpress.org/core/2015/06/03/feature-plugin-merge-proposal-menu-customizer/ for the original formal proposal to do so. And also, numerous other updates over the years at https://make.wordpress.org/core/?s=menu+customizer.

Menus in the customizer have already been rewritten into a JavaScript-based and scalable experience. The updates there should be able to extend that existing API rather than doing a complete rewrite, unlike in the menus screen. The wp-admin menus screen largely exists as a no-js fallback at this point, which likely wouldn't be able to be maintained with blocks.

Focusing on one version of this interface, preferably the more-modern one, which already supports instant live preview, would allow more resources to ensure that this "blockification" also improves the longstanding issues with menu accessibility and extensibility.

@afercia

This comment has been minimized.

Copy link
Contributor

afercia commented Jan 18, 2019

The customizer is not fully accessible. The admin menus screen is the only place where persons with accessibility needs have a chance to build menus without having to face big accessibility barriers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment