Sandbox embedded previews #1348
Labels
[Feature] Blocks
Overall functionality of blocks
Projects
Comments
|
Closed in #1392 |
youknowriad
pushed a commit
that referenced
this issue
Jan 17, 2020
* Add ref to PR 17325 * update ref
youknowriad
pushed a commit
that referenced
this issue
Jan 17, 2020
…rg-mobile into add/autosave-monitor * 'develop' of https://github.com/wordpress-mobile/gutenberg-mobile: [iOS]Fix: Oddly formatted text hangs Gutenberg (#1352) Remove redundant bg color within button appender (#1348) Update bundles Update package.json version to 1.12.0 # Conflicts: # bundle/android/App.js # bundle/android/App.js.map # bundle/ios/App.js # bundle/ios/App.js.map
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
At the moment, we're just injecting embedded content previews into the main editor document. We need to move over to using sandboxed iframes for this.
It's not as simple as it sounds, as we need to resize the iframe to show the full content of the preview and Calypso has a resizing iframe that attempts to do that, but some sites, like Tumblr, start resizing the content to fit the container, while the iframe is also resizing, and it all messes up.
Calypso has extra code to properly calculate the size of embedded content in the editor, which we should look at, and replace the current implementation of HtmlEmbed.
The text was updated successfully, but these errors were encountered: