Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add word count to post settings #1557

Closed
jwold opened this issue Jun 28, 2017 · 10 comments · Fixed by #2684
Closed

Add word count to post settings #1557

jwold opened this issue Jun 28, 2017 · 10 comments · Fixed by #2684
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time
Milestone

Comments

@jwold
Copy link

jwold commented Jun 28, 2017

Note: If this already exists elsewhere please close it. I tried to find a duplicate.

Would it be helpful to add word count into the post settings area for the whole document? If that's too much work at this point we can hold off.

word-count

@ellatrix
Copy link
Member

We can use the word counter module that is currently in core. https://github.com/WordPress/wordpress-develop/blob/master/src/wp-admin/js/word-count.js

@ellatrix ellatrix added the Good First Issue An issue that's suitable for someone looking to contribute for the first time label Jun 28, 2017
@ryanwelcher
Copy link
Contributor

I think what might make sense here is a Word Count for each editable text area that is displayed when the edit area is active. Then we can have an overall count based on the word counts for each editor that can be displayed in the same box
active-editor

@jwold
Copy link
Author

jwold commented Jun 30, 2017

I think what might make sense here is a Word Count for each editable text area that is displayed when the edit area is active. Then we can have an overall count based on the word counts for each editor that can be displayed in the same box

Do you often want to know the word count for a section of text you're working on? My only concern is I'm not sure if that's helpful. Usually when I'm writing articles I only care about the total word count. Keen on your thoughts. Thanks!

@ryanwelcher
Copy link
Contributor

That's a good point @jwold. From a technical standpoint, I think we're going to need to track the count for each text block in order to display the full count but that doesn't mean we need to display the per-instance count. This might become helpful if an editor wants a certain amount of copy in a text block that appears before a more link but that may be the exception rather than the rule.

@jasmussen
Copy link
Contributor

Added some comments on #1624 (comment), relevant to this discussion.

Also worth noting, we need a UI for when you have opened all the metaboxes in the sidebar (and probably keep them open, pending #450). In this configuration, would we want to use some trick to stick the counter at the bottom, in essentially a sidebar footer? Then you'd scroll the content between the sidebar header and sidebar footer.

@jwold
Copy link
Author

jwold commented Jul 3, 2017

would we want to use some trick to stick the counter at the bottom, in essentially a sidebar footer?

This might work. I think that could be a decent solution.

A few other ideas. I like how Bear Notes has a tooltip popup. It's something to at least consider (in mobile it would open another sidebar):

screen shot 2017-07-03 at 10 24 06 am

But since that could get confusing to have a post settings sidebar with a popup, I'm not sure. Thoughts?

@jasmussen
Copy link
Contributor

If we have to go with a counter in the main body, I like the dropdown idea from Bear that you screenshotted. Perhaps we could go super minimalist and instead of an icon just have a number. Instead of "123 Words", just "123", and then on click we could expand and show more.

@jwold
Copy link
Author

jwold commented Jul 3, 2017

@jasmussen I like that idea. Super simple in main body but popout to show more.

@mtias mtias added this to the Beta 1.2 milestone Aug 31, 2017
@mtias
Copy link
Member

mtias commented Aug 31, 2017

We could pair this with Table of Contents which counts headings alone.

@mtias
Copy link
Member

mtias commented Aug 31, 2017

Table of Contents could be moved to show as a popover as well on the main content like @jwold proposal.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants