Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block indication label goes over toolbar #16334

Closed
karmatosed opened this issue Jun 27, 2019 · 9 comments
Closed

Block indication label goes over toolbar #16334

karmatosed opened this issue Jun 27, 2019 · 9 comments
Labels
Needs Dev Ready for, and needs developer efforts [Type] Bug An existing feature does not function as intended

Comments

@karmatosed
Copy link
Member

The block indication label covers the toolbar, perhaps considering moving this to the right or iterating could avoid this?

2019-06-27 at 19 11

@kjellr kjellr added [Type] Bug An existing feature does not function as intended Needs Design Feedback Needs general design feedback. labels Jun 27, 2019
@kjellr
Copy link
Contributor

kjellr commented Jun 27, 2019

It'll be just a tiny bit better when #14961 lands:

Screen Shot 2019-06-27 at 2 25 17 PM

... but that will also come with more problems:

Screen Shot 2019-06-27 at 2 27 18 PM

In general, we've talked in other threads about removing these breadcrumbs entirely. I'm sort of leaning that towards, personally — I'm not convinced that knowing the type of block on hover is actually all that beneficial, especially as PRs like #14961 and #15537 make it easier to work within nested block situations.

@karmatosed
Copy link
Member Author

In general, we've talked in other threads about removing these breadcrumbs entirely.

If there isn't an option that doesn't have down-sides I do kind of agree with removing for now in light of those PRs.

@richtabor
Copy link
Member

In general, we've talked in other threads about removing these breadcrumbs entirely.

I'm also for removing these breadcrumbs.

@karmatosed karmatosed added Needs Dev Ready for, and needs developer efforts and removed Needs Design Feedback Needs general design feedback. labels Jul 3, 2019
@chrisvanpatten
Copy link
Member

chrisvanpatten commented Jul 9, 2019

I was pro-remove, but I've started work on a set of custom blocks for an internal project where the blocks are all very similar in appearance. For this case, having the labels has been truly invaluable, and I think removing them would be a mistake. (Would be happy to demo this privately, to show how the labels are valuable — just can't share the project publicly!)

@karmatosed
Copy link
Member Author

@chrisvanpatten How common is that project? I am not saying this isn't a use case, but I really wonder if most find it a problem that another solution wouldn't be better than one that for most causes issues.

@kjellr
Copy link
Contributor

kjellr commented Jul 10, 2019

I opened a quick PR to try out the removal of these breadcrumbs entirely: #16506

@bigvibes909
Copy link

Please, please get rid of these labels.

As an editor I work with WordPress on multiple sites all day and I can't tell you how much lost productivity I've had to deal with due to these labels. This issue I'm sure is one of the reasons people swear at Gutenberg since it actually makes using WordPress unusable.

I'd think just about everyone would agree that just being able to simply use the editor is the most important thing rather than having all these minimally used bells and whistles.

@ZebulanStanphill
Copy link
Member

@bigvibes909 There is a pull request which, if merged, will remove the hover indicators entirely: #18862.

@ZebulanStanphill
Copy link
Member

Closing since #18862 has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Dev Ready for, and needs developer efforts [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

6 participants