Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button Block: Refactor to avoid cropping the URL input field #17086

Closed
kjellr opened this issue Aug 19, 2019 · 3 comments
Closed

Button Block: Refactor to avoid cropping the URL input field #17086

kjellr opened this issue Aug 19, 2019 · 3 comments
Labels
[Block] Buttons Affects the Buttons Block [Type] Bug An existing feature does not function as intended

Comments

@kjellr
Copy link
Contributor

kjellr commented Aug 19, 2019

When a button has short text, the URL input field is cropped initially, cutting off part of its placeholder text:

button-crop

This should be adjusted so that the text isn't cut off, but so that it will (ideally) still fit in areas where there isn't much room.


Originally noted in #17063, related to updates made in #16873.

@kjellr kjellr added [Type] Bug An existing feature does not function as intended [Block] Buttons Affects the Buttons Block labels Aug 19, 2019
@talldan
Copy link
Contributor

talldan commented Oct 18, 2019

A couple of other issues that might also have resulted from #16873.

The movers are incorrectly sized when a left/right alignment is set on the button block:
Screen Shot 2019-10-18 at 2 50 23 pm

Block warnings aren't full width for the button block:
Screen Shot 2019-10-18 at 2 51 14 pm

@skorasaurus
Copy link
Member

skorasaurus commented Nov 20, 2020

I came across this while debugging another button issue; this appears to now be fixed; I'm unable to reproduce this, regardless what alignment is used.

Below is what appears even while emulating a small moto4 (width 360px) in chrome
zach test_wp-admin_post php_post=8 action=edit(Moto G4)

@kjellr
Copy link
Contributor Author

kjellr commented Nov 20, 2020

It is! The URL field has moved back into a popover, so this is no longer an issue. Thanks for the nudge!

@kjellr kjellr closed this as completed Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Buttons Affects the Buttons Block [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

3 participants