Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a "keyboard shortcut" treatment to the default tip in the inserter modal #17111

Closed
kjellr opened this issue Aug 20, 2019 · 2 comments · Fixed by #18623
Closed

Add a "keyboard shortcut" treatment to the default tip in the inserter modal #17111

kjellr opened this issue Aug 20, 2019 · 2 comments · Fixed by #18623
Assignees
@gziolo
Labels
[Feature] Inserter The main way to insert blocks using the + button in the editing interface Good First Issue An issue that's suitable for someone looking to contribute for the first time [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@kjellr
Copy link
Contributor

kjellr commented Aug 20, 2019

Followup from #16813.

The default tip in the inserter modal currently says:

Screen Shot 2019-08-20 at 11 41 47 AM

To make the / part of this message more clear, we should treat the / similar to how Gutenberg displays keyboard shortcuts in the shortcuts modal:

code
@kjellr kjellr added [Type] Enhancement A suggestion for improvement. Good First Issue An issue that's suitable for someone looking to contribute for the first time Needs Design Feedback Needs general design feedback. labels Aug 20, 2019
@kjellr kjellr mentioned this issue Aug 20, 2019
Closed
@mapk
Copy link
Contributor

mapk commented Aug 27, 2019

Yes please. This change would make a lot of sense.

My only question is... would we need to update it here as well?

Screen Shot 2019-08-27 at 9 28 14 AM

@mapk mapk added Needs Dev Ready for, and needs developer efforts and removed Needs Design Feedback Needs general design feedback. labels Aug 27, 2019
@kjellr
Copy link
Contributor Author

kjellr commented Aug 27, 2019

Yeah, maybe! We may end up revising/removing that inline tip now that it's also included in the panel but that probably makes sense in the meantime.

@enriquesanchez enriquesanchez self-assigned this Aug 27, 2019
@enriquesanchez enriquesanchez mentioned this issue Aug 27, 2019
Closed
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Aug 27, 2019
@gziolo gziolo removed the [Status] In Progress Tracking issues with work in progress label Oct 21, 2019
@gziolo gziolo mentioned this issue Nov 20, 2019
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Nov 20, 2019
@gziolo gziolo added [Feature] Inserter The main way to insert blocks using the + button in the editing interface and removed Needs Dev Ready for, and needs developer efforts labels Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gziolo gziolo

Labels
[Feature] Inserter The main way to insert blocks using the + button in the editing interface Good First Issue An issue that's suitable for someone looking to contribute for the first time [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
4 participants
@mapk @gziolo @kjellr @enriquesanchez