Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation Block: highlight items missing a URL #18305

Closed
mtias opened this issue Nov 6, 2019 · 1 comment · Fixed by #18435
Closed

Navigation Block: highlight items missing a URL #18305

mtias opened this issue Nov 6, 2019 · 1 comment · Fixed by #18435
Assignees
Labels
[Block] Navigation Affects the Navigation Block Needs Design Needs design efforts.

Comments

@mtias
Copy link
Member

mtias commented Nov 6, 2019

In the navigation menu block, it's possible to have a menu item without a URL set. There's nothing in the UI that indicates a menu doesn't have a link set.

image

It'd be great to indicate that — could be as simple as a red bottom border on the item.

Likewise in this view, the link item in the toolbar looks the same way whether there's a URL set or not.
image

cc @shaunandrews @karmatosed

@mtias mtias added Needs Design Needs design efforts. [Block] Navigation Affects the Navigation Block labels Nov 6, 2019
@retrofox retrofox added this to 🗂 To do in Navigation editor via automation Nov 11, 2019
@retrofox retrofox self-assigned this Nov 11, 2019
@retrofox retrofox moved this from 🗂 To do to 💻 Issues in progress in Navigation editor Nov 11, 2019
@retrofox
Copy link
Contributor

It'd be great to indicate that — could be as simple as a red bottom border on the item.

Wondering what happens when the bgc is red? 😆

What do you think about setting the same color as the item link?

Navigation editor automation moved this from 💻 Issues in progress to ✅ Done Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block Needs Design Needs design efforts.
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants