Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blocks: Separator: Background style is too specific #19539

Open
joyously opened this issue Jan 9, 2020 · 2 comments
Open

Blocks: Separator: Background style is too specific #19539

joyously opened this issue Jan 9, 2020 · 2 comments
Labels
[Block] Separator Affects the Separator Block [Type] Enhancement A suggestion for improvement.

Comments

@joyously
Copy link

joyously commented Jan 9, 2020

Describe the bug

gutenberg/packages/block-library/src/separator/style.scss

Line 13 in 2d908df

background: none !important;

The style for the separator block uses !important, making it so the theme has to also use !important to override the style.
Perhaps these styles should be in the theme.css instead of style.css, so they can be optional?
@aduth aduth mentioned this issue Jan 9, 2020
Merged
@aduth
Copy link
Member

aduth commented Jan 9, 2020

Related: #16784 (https://github.com/WordPress/gutenberg/pull/16784/files#r364954401)

@aduth aduth changed the title Separator style is too specific Blocks: Separator: Background style is too specific Jan 9, 2020
@aduth aduth added [Block] Separator Affects the Separator Block [Feature] Themes Questions or issues with incorporating or styling blocks in a theme. labels Jan 9, 2020
@paaljoachim paaljoachim mentioned this issue Oct 5, 2020
Closed
@jordesign jordesign added [Type] Enhancement A suggestion for improvement. and removed [Feature] Themes Questions or issues with incorporating or styling blocks in a theme. labels Aug 16, 2023
@jordesign
Copy link
Contributor

Noting that this behaviour is still the case (!important being added when a background is selected) but given it is the norm now to expect that a user can overide the theme's styles when specifically setting a background - I wonder if this is ok, and the issue can be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Block] Separator Affects the Separator Block [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@aduth @jordesign @joyously