Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation: Improve how non-link blocks appear in old nav-menus.php screen #24639

Closed
Tracked by #29102
noisysocks opened this issue Aug 19, 2020 · 2 comments
Closed
Tracked by #29102
Labels
Needs Design Needs design efforts.

Comments

@noisysocks
Copy link
Member

If a user activates a theme that has add_theme_support( 'block-nav-menus' ), adds a non-link block to their Navigation, and then opens the old Menus screen (nav-menus.php), they will see the block they added as a Block menu item like so:

Screen Shot 2020-08-19 at 11 09 42

There's a few improvements we could make here:

  • Prevent user from being able to nest menu items underneath a Block menu item, since in most cases this requires changing the HTML in the Block menu item.

  • If the theme does not have add_theme_support( 'block-nav-menus' ), properly indicate that the menu item will not display on the frontend.

See #24503 (comment).

@noisysocks
Copy link
Member Author

If the theme does not have add_theme_support( 'block-nav-menus' ), properly indicate that the menu item will not display on the frontend.

We'll need a simple design for this.

@Thelmachido
Copy link

Closing this issue due to the Navigation Editor project being moved to an inactive status on the feature projects page in coordination with the project leads. If this work is picked back up, issues can be revisited and reopened as needed.

The work will continue on the navigation block.

@Thelmachido Thelmachido closed this as not planned Won't fix, can't repro, duplicate, stale Sep 20, 2022
Navigation editor automation moved this from Design to Done Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Design Needs design efforts.
Projects
No open projects
Development

No branches or pull requests

2 participants