Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit tests for all of the exported functions in packages/edit-widgets/store #25406

Open
adamziel opened this issue Sep 17, 2020 · 1 comment
Open

Add unit tests for all of the exported functions in packages/edit-widgets/store #25406

adamziel opened this issue Sep 17, 2020 · 1 comment
Labels
[Feature] Widgets Screen The block-based screen that replaced widgets.php. Needs Dev Ready for, and needs developer efforts [Package] Edit Widgets /packages/edit-widgets [Type] Code Quality Issues or PRs that relate to code quality
Projects
Block-based Widgets Editor

Comments

@adamziel
Copy link
Contributor

Originally reported in #24290 (review)
@adamziel adamziel created this issue from a note in Block-based Widgets Editor (Needs dev) Sep 17, 2020
@adamziel adamziel added [Feature] Widgets Screen The block-based screen that replaced widgets.php. [Package] Edit Widgets /packages/edit-widgets labels Sep 17, 2020
@noisysocks noisysocks added the [Type] Code Quality Issues or PRs that relate to code quality label Oct 1, 2020
@noisysocks
Copy link
Member

While doing this it'd be worth auditing all the function names and JSDoc comments. I see the word "navigation" in a few places which is leftover from the initial copy/paste from edit-navigation. Also, every exported function in /store should have a JSDoc comment.

@draganescu draganescu mentioned this issue Feb 18, 2021
Closed
53 tasks
@noisysocks noisysocks moved this from Needs dev to Maybe later in Block-based Widgets Editor Jun 25, 2021
@noisysocks noisysocks changed the title [Widgets editor] Add unit tests for all of the exported functions in packages/edit-widgets/store Add unit tests for all of the exported functions in packages/edit-widgets/store Jan 27, 2022
@noisysocks noisysocks added the Needs Dev Ready for, and needs developer efforts label Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] Widgets Screen The block-based screen that replaced widgets.php. Needs Dev Ready for, and needs developer efforts [Package] Edit Widgets /packages/edit-widgets [Type] Code Quality Issues or PRs that relate to code quality
Projects
No open projects
Block-based Widgets Editor
Maybe later
Milestone
No milestone
Development

No branches or pull requests
2 participants
@adamziel @noisysocks