Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve accessibility hierarchy of document title area #25781

Closed
noahtallen opened this issue Oct 1, 2020 · 3 comments · Fixed by #25874
Closed

Improve accessibility hierarchy of document title area #25781

noahtallen opened this issue Oct 1, 2020 · 3 comments · Fixed by #25874
Assignees
Labels
[Type] Enhancement A suggestion for improvement.

Comments

@noahtallen
Copy link
Member

To improve the hierarchy of the document area, we can use flex-basis to set the document area as the first semantic element. This could be a logical improvement to help re-enforce it as the top level of the hierarchy.

I think this is an example were flex-order can be employed to good effect, since it'd align the semantic hierarchy with the perceived visual hierarchy, so we can have the title control first in the DOM and centered visually
@matias in #20877 (comment)

@Addison-Stavlo
Copy link
Contributor

Hopefully - #25874 - is what we are talking about? Make it the first element and use order flex property to keep the same visual layout.

@Addison-Stavlo Addison-Stavlo self-assigned this Oct 6, 2020
@noahtallen
Copy link
Member Author

That was the idea yes -- I want to also note that there have been a few comments that this is an antipattern and there could be better ways to solve the problem.

@Addison-Stavlo
Copy link
Contributor

I want to also note that there have been a few comments that this is an antipattern

Ah I see that now.

and there could be better ways to solve the problem.

I see suggestions to use headings to help screen reader navigation, but does that solve the problems for why we wanted this to appear first in the hierarchy (@mtias)?

The only other solution I see suggested is to move the toolbar group on the left out of the main header altogether so this document-actions can be left-aligned and the first visually as well. Until that is agreed upon and done, Im not sure there is another way to achieve this?

@noahtallen noahtallen changed the title Order "document actions area" as first element Improve accessibility hierarchy of document title area Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants