Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add empty or existing category: error 500 #2581

Closed
afercia opened this issue Aug 28, 2017 · 1 comment · Fixed by #2623
Closed

Add empty or existing category: error 500 #2581

afercia opened this issue Aug 28, 2017 · 1 comment · Fixed by #2623
Assignees
Labels
[Type] Bug An existing feature does not function as intended

Comments

@afercia
Copy link
Contributor

afercia commented Aug 28, 2017

To reproduce:

  • open the "Add New Category" form in the sidebar
  • submit testing all these 3 cases:
    • leave the new category field empty
    • enter only spaces
    • enter an already existing category
  • observe your browser console
  • POST ... 500 (Internal Server Error)

As far as I zee, there is a response, for example:
{"code":"empty_term_name","message":"A name is required for this term.","data":null}
but maybe it's not handled correctly

Also, the UI doesn't give any feedback in both cases. At the very least, I'd consider to:

  • don't allow user to submit an empty term name or made of only spaces
  • handle the already existing term correctly: the UI should display a proper message and also send an audible message to the ARIA live region
@afercia afercia added the [Type] Bug An existing feature does not function as intended label Aug 28, 2017
@youknowriad
Copy link
Contributor

Adding an existing category has been fixed, it's now selected. We can't get rid of the 500 because of an API limitation where we can not fetch an existing term before trying to create It.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants