Add new category form improvements #2588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afercia
added
the
[Focus] Accessibility (a11y)
Codecov Report
@@ Coverage Diff @@
## master #2588 +/- ##
==========================================
+ Coverage 31.68% 32.64% +0.96%
==========================================
Files 175 177 +2
Lines 5312 5881 +569
Branches 915 1093 +178
==========================================
+ Hits 1683 1920 +237
- Misses 3081 3304 +223
- Partials 548 657 +109
Continue to review full report at Codecov.
|
youknowriad
reviewed
Aug 29, 2017
| @@ -114,7 +115,7 @@ class HierarchicalTermSelector extends Component { | |||
| adding: false, | |||
| formName: '', | |||
| formParent: '', | |||
| showForm: false, | |||
There was a problem hiding this comment.
I guess we could drop it entirely here
afercia
changed the title
|
Visual comparison of the form, from left to right: before, after, after with focused elements:
|
Previously closed form after add, now leaves _as is_, so no need to explicitly assigned
aduth
approved these changes
Sep 1, 2017
There was a problem hiding this comment.
I made suggested changes per https://github.com/WordPress/gutenberg/pull/2588/files#r135794709 in f769c91. Looks good 👍
|
Thanks! Will split a few pending improvements in a new issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to improve a bit the accessibility of the mini-form used to add new categories. Further improvements should be addressed in separate issues, see #2582 and #2581.
withInstanceIdbutton-links used in the sidebar, e.g. "set featured image"type="text"to the input field (this also fixes the focus style)aria-expandedto the toggleFixes #2572