Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widget Editor: When SHIFT + TAB ing to the top, some problems arise #25876

Closed
mapk opened this issue Oct 6, 2020 · 2 comments
Closed

Widget Editor: When SHIFT + TAB ing to the top, some problems arise #25876

mapk opened this issue Oct 6, 2020 · 2 comments
Labels
[Feature] Widgets Screen The block-based screen that replaced widgets.php. [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Needs Accessibility Feedback Need input from accessibility Needs Dev Ready for, and needs developer efforts [Type] Bug An existing feature does not function as intended

Comments

@mapk
Copy link
Contributor

mapk commented Oct 6, 2020

Two issues here.

1. "Select parent (widget area) doesn't show a selection

In the screencast below, I was using SHIFT + TAB to keyboard back to the top and got to a point where it said "Select parent (widget area)" but didn't show that anything was selected. My guess is that the widget area was selected but it was not highlighted with a blue border. It should be highlighted with a blue border.

2. Add block above top block

In the screencast below, I was using SHIFT + TAB to keyboard back to the top and an Add block + appeared which was awkward. I suggest that doesn't appear above the first block in the widget area.

add-block

@mapk mapk added [Type] Bug An existing feature does not function as intended Needs Dev Ready for, and needs developer efforts [Feature] Widgets Screen The block-based screen that replaced widgets.php. labels Oct 6, 2020
@mapk mapk added this to Inbox in Block-based Widgets Editor via automation Oct 6, 2020
@mapk mapk changed the title Widget Editor: Add block + icon appears at top when SHIFT + TAB ing to the top Widget Editor: When SHIFT + TAB ing to the top, some problems arise Oct 6, 2020
@mapk mapk added [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Needs Accessibility Feedback Need input from accessibility labels Oct 6, 2020
@noisysocks noisysocks moved this from Inbox to Needs dev in Block-based Widgets Editor Oct 7, 2020
@talldan
Copy link
Contributor

talldan commented Oct 19, 2020

Issue 1 should have been solved by #26011, that button isn't present at all any more.

For Issue 2, this also happens in the post editor. I don't think we'd be able to apply a fix just for the widget editor, Ideally any change works across editors. I think it needs accessibility feedback too before a dev works on it, as it removes one of the ways a block can be added between blocks. It'd probably be quite difficult to add between blocks without this button, the more menu option is possible, but only inserts paragraphs.

BTW, there have been improvements now from the previous screenshots, there was a bug in the widget area CSS that removed some margin that was previously present, now the Add Block button at least shows within the widget area:
Screenshot 2020-10-19 at 5 22 45 pm

@mapk
Copy link
Contributor Author

mapk commented Oct 19, 2020

Thanks for solving issue 1.

And you're right about issue 2. I never realized that. I'll close this issue because it's definitely not solely related to the Widget Editor.

Screen Shot 2020-10-19 at 1 38 52 PM

@mapk mapk closed this as completed Oct 19, 2020
Block-based Widgets Editor automation moved this from Needs dev to Done Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Widgets Screen The block-based screen that replaced widgets.php. [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Needs Accessibility Feedback Need input from accessibility Needs Dev Ready for, and needs developer efforts [Type] Bug An existing feature does not function as intended
Projects
No open projects
Development

No branches or pull requests

2 participants