Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global Styles: Should we Allow CSS properties that we don't manage at the moment? #27231

Open
jorgefilipecosta opened this issue Nov 24, 2020 · 4 comments
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json Needs Decision Needs a decision to be actionable or relevant [Type] Enhancement A suggestion for improvement.

Comments

@jorgefilipecosta
Copy link
Member

In theme.json should we generate styles for properties we don't manage or provide an explicit UI control?
E.g. if a theme passes:

"core/paragraph": {
	"styles": {
		"textShadow": "2px 2px pink";
	}
}

Or

"core/paragraph": {
	"customStyles": {
		"textShadow": "2px 2px pink";
	}
}

Should we generate text-shadow styles for the paragraph or not?

@jorgefilipecosta jorgefilipecosta added the Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json label Nov 24, 2020
@aristath
Copy link
Member

YES!!!
If we do this then we're getting closer to a full JSON-based theme. Technically there's nothing stopping us from doing this... If we don't do it, then theme-authors will just add them to a stylesheet. which is fine, but not as good as having a single-source-of-truth in the JSON file ❤️

@pagelab
Copy link
Contributor

pagelab commented Dec 1, 2020

If we do this then we're getting closer to a full JSON-based theme

It would be truly awesome to see that happen.

@carolinan
Copy link
Contributor

This would be great or even necessary :)

@skorasaurus skorasaurus added the Needs Decision Needs a decision to be actionable or relevant label Mar 6, 2023
@jordesign jordesign added the [Type] Enhancement A suggestion for improvement. label Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json Needs Decision Needs a decision to be actionable or relevant [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

7 participants
@aristath @skorasaurus @pagelab @jordesign @carolinan @jorgefilipecosta and others